BREAKING CHANGE: Deprecating old APIs in Auth #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror (#680) Initial change to make sure Unity SDK can compile against C++ Auth feature branch. Integration test is expected to be broken since it is pointing to C++ main and Unity integration test is not update. This change includes: - Update SWIG postprocess to rename deprecated functions which returns a `Task` - Remove `PhoneAuthProvider.MaxTimeoutMs` - Wire the following function to new C++ impl - `Firebase.Auth.FirebaseAuth.CurrentUser` - `Firebase.Auth.FirebaseUser.ProviderData` - Deprecated the following function - Firebase.Auth.FirebaseAuth.SignInWithCustomTokenAsync_DEPRECATED - Firebase.Auth.FirebaseAuth.SignInWithCredentialAsync_DEPRECATED - Firebase.Auth.FirebaseAuth.SignInAndRetrieveDataWithCredentialAsync_DEPRECATED - Firebase.Auth.FirebaseAuth.SignInAnonymouslyAsync_DEPRECATED - Firebase.Auth.FirebaseAuth.SignInWithEmailAndPasswordAsync_DEPRECATED - Firebase.Auth.FirebaseAuth.CreateUserWithEmailAndPasswordAsync_DEPRECATED - Firebase.Auth.FirebaseAuth.SignInWithProviderAsync_DEPRECATED - Firebase.Auth.FirebaseUser.ReauthenticateWithProviderAsync_DEPRECATED - Firebase.Auth.FirebaseUser.LinkWithProviderAsync_DEPRECATED - Added C# impl for new `PhoneAuthOptions` class - Placeholder impl for `PhoneAuthListenerImpl.OnVerificationCompleted(PhoneAuthCredential)`
Rename and deprecated the following methods - `FirebaseUser.LinkAndRetrieveDataWithCredentialAsync_DEPRECATED()` - `FirebaseUser.LinkWithCredentialAsync_DEPRECATED()` - `FirebaseUser.ReauthenticateAndRetrieveDataAsync_DEPRECATED()` - `FirebaseUser.UnlinkAsync_DEPRECATED()` - `FirebaseUser.UpdatePhoneNumberCredentialAsync_DEPRECATED()` - `PhoneAuthProvider.VerificationCompleted_DEPRECATED` - `PhoneAuthProvider.VerifyPhoneNumber()` - `PhoneAuthProvider.GetCredential_DEPRECATED()`
Since C++ API changed to return `User` as a value, C# API will always created one object pointing to different CPtr while they are all referencing the same user. This change added `Firebase.IsValid` and also use comparison operator when updating `FirebaseAuth.currentUser`.
a-maurice
approved these changes
May 4, 2023
chkuang-g
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change includes:
PhoneAuthProvider.MaxTimeoutMsFirebase.Auth.FirebaseAuth.CurrentUserFirebase.Auth.FirebaseUser.ProviderDataFirebaseUser.LinkAndRetrieveDataWithCredentialAsync_DEPRECATED()FirebaseUser.LinkWithCredentialAsync_DEPRECATED()FirebaseUser.ReauthenticateAndRetrieveDataAsync_DEPRECATED()FirebaseUser.UnlinkAsync_DEPRECATED()FirebaseUser.UpdatePhoneNumberCredentialAsync_DEPRECATED()PhoneAuthProvider.VerificationCompleted_DEPRECATEDPhoneAuthProvider.VerifyPhoneNumber()PhoneAuthProvider.GetCredential_DEPRECATED()Firebase.Auth.FirebaseAuth.SignInWithCustomTokenAsync_DEPRECATEDFirebase.Auth.FirebaseAuth.SignInWithCredentialAsync_DEPRECATEDFirebase.Auth.FirebaseAuth.SignInAndRetrieveDataWithCredentialAsync_DEPRECATEDFirebase.Auth.FirebaseAuth.SignInAnonymouslyAsync_DEPRECATEDFirebase.Auth.FirebaseAuth.SignInWithEmailAndPasswordAsync_DEPRECATEDFirebase.Auth.FirebaseAuth.CreateUserWithEmailAndPasswordAsync_DEPRECATEDFirebase.Auth.FirebaseAuth.SignInWithProviderAsync_DEPRECATEDFirebase.Auth.FirebaseUser.ReauthenticateWithProviderAsync_DEPRECATEDFirebase.Auth.FirebaseUser.LinkWithProviderAsync_DEPRECATEDPhoneAuthOptionsclassPhoneAuthListenerImpl.OnVerificationCompleted(PhoneAuthCredential)Testing
Build: https://github.com/firebase/firebase-unity-sdk/actions/runs/4879946559
Test: https://github.com/firebase/firebase-unity-sdk/actions/runs/4880313451
Type of Change
Place an
xthe applicable box: