Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xcode to 14.1 and simulators to GitHub-compatible versions. #701

Merged
merged 2 commits into from
May 5, 2023
Merged

Update Xcode to 14.1 and simulators to GitHub-compatible versions. #701

merged 2 commits into from
May 5, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Xcode 14.1 is now Apple's minimum allowed version - and GitHub runners are no longer guaranteed to have the older simulators installed.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@jonsimantov jonsimantov requested a review from a-maurice May 4, 2023 20:50
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 4, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 4, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 9a669dd
Last updated: Fri May 5 03:14 PDT 2023
View integration test log & download artifacts

Failures Configs
installations [TEST] [FAILURE] [2020] [1/2 Build OS(s): windows] [1/6 Platform(s): Windows] [1/3 Test Device(s): github_runner]
messaging [TEST] [ERROR] [2020] [1/2 Build OS(s): macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 5, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2023
@jonsimantov jonsimantov merged commit ebeb50d into main May 5, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 5, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2023
@firebase firebase locked and limited conversation to collaborators Jun 5, 2023
@a-maurice a-maurice deleted the use-xcode-14.1 branch May 8, 2024 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice