Remove accidentally swig generated field FirebaseUser.provider_data_DEPRECATED #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlmostMatt
changed the title
chkuang-g
approved these changes
May 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
C++ Auth User has
provider_data() std::vector< UserInfoInterface >
provider_data_DEPRECATED() std::vector< UserInfoInterface * > &
Unity Auth FirebaseUser has
ProviderData IEnumerable< IUserInfo >
provider_data_DEPRECATED() SWIGTYPE_p_std__vectorT_firebase__auth__UserInfoInterface_p_t
Since the type for Unity ProviderData has not changed as part of the 11.0.0 release, the Unity provider_data_DEPRECATED field can just be deleted.
Testing
Built Auth locally and inspected the generated C# code. Verified that the provider_data_DEPRECATED method is no longer generated.
Type of Change
Place an
xthe applicable box: