Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_messaging] Documentation and example out of sync 6.0.9 #1657

Closed
ninnepinne opened this issue Dec 16, 2019 · 2 comments
Closed

[firebase_messaging] Documentation and example out of sync 6.0.9 #1657

ninnepinne opened this issue Dec 16, 2019 · 2 comments
Labels
plugin: messaging type: documentation Improvements or additions to documentation

Comments

@ninnepinne
Copy link
Contributor

ninnepinne commented Dec 16, 2019

Describe the bug
The documentation and the example project are out of sync.

To make matters worse there are a lot of issues with the latest release: #1606 (and some other related and linked to this)

To Reproduce

  1. Read and follow the documentation.
  2. You might enjoy failing builds and inconsistent behaviour.
  3. Look into the example project to verify your code and setup (by comparison).
  4. Discover that the example project handles plugin registration completely different from what is described in the documentation. Different code and different versions.
  5. Feel utterly confused ;-)

Which method should be used?

Expected behavior
The example and the documentation should be using the same code.

@ninnepinne ninnepinne added the type: bug Something isn't working label Dec 16, 2019
@Dr-Legend
Copy link

Dr-Legend commented Dec 16, 2019

same for me, using 6.0.1 nope not working :/

@ninnepinne ninnepinne changed the title [firebase_messaging] Documentation and example of of sync 6.0.9 [firebase_messaging] Documentation and example out of sync 6.0.9 Dec 16, 2019
@Ehesp Ehesp added plugin: messaging type: documentation Improvements or additions to documentation and removed type: bug Something isn't working labels Apr 23, 2020
Ehesp pushed a commit that referenced this issue Oct 20, 2020
…arameters to invokeMethod calls, bump min Flutter version to 1.5.0 (#1657)
@Salakar
Copy link
Member

Salakar commented Nov 5, 2020

Hey all 👋

As part of our roadmap (#2582) we've just shipped a complete rework of the firebase_messaging plugin that aims to solve this and many other issues.

If you can, please try out the dev release (see the migration guide for upgrading and for changes) and if you have any feedback then join in the discussion here.

Given the scope of the rework I'm going to go ahead and close this issue in favor of trying out the latest plugin.

Thanks everyone.

@Salakar Salakar closed this as completed Nov 5, 2020
@firebase firebase locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: messaging type: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants