Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui_auth): fix OAuth providers on RegisterScreen #10026

Merged
merged 2 commits into from
Dec 1, 2022
Merged

fix(ui_auth): fix OAuth providers on RegisterScreen #10026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4504de
fix(ui_auth): fix OAuth providers on RegisterScreen
lesnitsky Nov 30, 2022
ea21969
Update packages/firebase_ui_auth/lib/src/providers/auth_provider.dart
lesnitsky Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/firebase_ui_auth/lib/src/providers/auth_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,14 @@ abstract class AuthProvider<T extends AuthListener, K extends AuthCredential> {
linkWithCredential(credential);
break;
case AuthAction.signIn:
// Only email provider has a different action for sign in and sign up
// and implements it's own sign up logic.
case AuthAction.signUp:
signInWithCredential(credential);
break;
case AuthAction.none:
authListener.onCredentialReceived(credential);
break;
default:
throw Exception('$runtimeType should handle $action');
}
}
}