feat(ui_storage): configuration API and UploadButton widget #10699
Conversation
| cmake_minimum_required(VERSION 3.10) | ||
| project(runner LANGUAGES CXX) | ||
|
|
||
| # The name of the executable created for the application. Change this to change | ||
| # the on-disk name of your application. | ||
| set(BINARY_NAME "firebase_ui_example") | ||
| # The unique GTK application identifier for this application. See: | ||
| # https://wiki.gnome.org/HowDoI/ChooseApplicationID |
There was a problem hiding this comment.
Should we remove the linux folder since we don't support it?
There was a problem hiding this comment.
we do support it via flutterfire_desktop 😉
| # Project-level configuration. | ||
| cmake_minimum_required(VERSION 3.14) | ||
| project(firebase_ui_example LANGUAGES CXX) | ||
|
|
||
| # The name of the executable created for the application. Change this to change | ||
| # the on-disk name of your application. | ||
| set(BINARY_NAME "firebase_ui_example") | ||
|
|
||
| # Explicitly opt in to modern CMake behaviors to avoid warnings with recent |
There was a problem hiding this comment.
flutterfire_desktop will work on windows too :)
| /// | ||
| /// See also: | ||
| /// * [KeepOriginalNameUploadPolicy] | ||
| abstract class FileUploadNamingPolicy { |
| final config = context.configFor(storage); | ||
|
|
||
| return LoadingButton( | ||
| label: 'Upload file', // TOOD(lesnitsky): i18n |
There was a problem hiding this comment.
If we only support english for the first release, maybe we should remember to put that into the release note
There was a problem hiding this comment.
that would be a dev release anyways, but yeah, could mention that
| cupertinoIcon: CupertinoIcons.cloud_upload, | ||
| materialIcon: Icons.upload_outlined, |
There was a problem hiding this comment.
If I want the same Button on Android and iOS, will I still have to fill both of them? Will I be able to control the appearance manually (like having a "Cupertino" button on Android?)
There was a problem hiding this comment.
this is not platform specific, but rather top-level app specific. so if you use MaterialApp both for ios and android – material button will be used. If you want ios widgets – you need to use CupertinoApp.
both fields are optional, so you could pass only one for the type of app you use
There was a problem hiding this comment.
Ok great, I wasn't sure when reading the PR, but it's what I had in mind thanks :D
Related Issues
Closes #10698
Closes #10380
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?