-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move to macOS 13 runner #10841
Merged
ci: move to macOS 13 runner #10841
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
0501369
ci: move to macOS 13 XL runner
Lyokone 79b8bdf
ci: update iOS simulator
Lyokone 3df055b
ci: update iOS simulator
Lyokone bf9357e
ci: move firebase_performance to main tests
Lyokone b952e12
ci: move firebase_performance to main tests
Lyokone 81bf47e
ci: update flutter version for macos
Lyokone f4366a4
ci: update flutter version for macos
Lyokone b5ce743
ci: tests
Lyokone c730f3b
ci: tests
Lyokone 7bbad52
ci: tests
Lyokone dee7be2
ci: tests
Lyokone a0a980b
ci: tests
Lyokone 09189b3
ci: tests
Lyokone 9819327
ci: tests
Lyokone 42c93c1
ci: tests
Lyokone 19e56e0
ci: tests
Lyokone 25f0021
ci: tests
Lyokone 8af293a
ci: tests
Lyokone 99c55ef
ci: tests
Lyokone b40e1f4
ci: tests
Lyokone dc5213d
ci: tests
Lyokone e79a22f
ci: tests
Lyokone 4f8f33e
ci: final
Lyokone dd208cb
ci: manual android emulator
Lyokone d0882ab
ci: manual android emulator
Lyokone b8d79c0
ci: manual android emulator
Lyokone 14eb60e
ci: fix android notification request and cloud firestore package name
Lyokone 34a92fc
ci: fix android notification request and cloud firestore package name
Lyokone cf61a96
ci: fix android notification request and cloud firestore package name
Lyokone 7505849
ci: fix android notification request and cloud firestore package name
Lyokone 5945b27
ci: fix android notification request and cloud firestore package name
Lyokone 9606a25
ci: fix android notification request and cloud firestore package name
Lyokone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised this yields a positive result! Really cool if so.
What I observed on multiple runs where the AVD cache was pre-generated (before API33 at least...) was lower performance on the first run (obviously) but if the AVD cache was pushed on main branch only so it wasn't evicted from github's cache, subsequent runs on main and all PR branches were much faster as a performance benefit
What I further observed was that the emulator performs lots of "first run" type things on it's first boot, so when I gave the emulator time to do that during AVD cache generation - meaning it was already "warm" for cache hits, I actually had greater stability as well, since there were some "first run" type things that failed sometimes (Zygote initial memory setting, for instance, or just race conditions with test operations) that resulted in better AVD stability on cache-hit runs / less flakes, as a stability benefit
If your new CI AVD strategy results in similar or better performance and stability, I need to look at this in react-native-firebase