Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, ios): fix scoping of import for message.g.h, could cause incompatibility with other packages #11300

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jul 17, 2023

Description

Importing messages.g.h could cause issues in other packages if they are using the same file name.

Related Issues

closes #11285

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit 91ccc57 into master Jul 17, 2023
15 of 18 checks passed
@Lyokone Lyokone deleted the fix/11285 branch July 17, 2023 14:20
@Tom3652
Copy link

Tom3652 commented Jul 19, 2023

Hello !

Just to say that the issue persists with 4.7.1 :

Could not build the precompiled application for the device.
Lexical or Preprocessor Issue (Xcode): 'messages.g.h' file not found
/Users/foxtom/.pub-cache/hosted/pub.dev/firebase_auth-4.7.1/ios/Classes/messages.g.m:3:8

@Lyokone
Copy link
Contributor Author

Lyokone commented Jul 20, 2023

Hi @Tom3652, I couldn't reproduce the issue with the last release on my end. Could you share your setup? Thanks

@joshuariveramnltech
Copy link

@Lyokone I too was able to replicate @Tom3652 's issue, and was able to fix it by changing the header of /firebase_auth-4.7.1/ios/Classes/messages.g.m:3:8

From:

#import "messages.g.h"

To:

#import <firebase_auth/messages.g.h>

@Tom3652
Copy link

Tom3652 commented Jul 24, 2023

@joshuariveramnltech thanks it works with your change !
@Lyokone my setup is doing flutter pub cache clean and then flutter pub get on the latest firebase_auth: 4.7.1 + file_selector package, build on my iPhone and see the error

@joshuariveramnltech
Copy link

Thanks @Tom3652 for checking, @Lyokone I am also using file_selector on my end and i think thats what causing this issue

@RWolfing
Copy link

RWolfing commented Aug 3, 2023

@Lyokone this issue seems to be reintroduced as firebase_auth/ios/Classes/messages.g.m was regenerated in this PR #10802 and the import changed from #import "Public/messages.g.h" to #import "messages.g.h". Resulting in the error described here #11409.

@Mounix99
Copy link

Mounix99 commented Aug 8, 2023

Any updates on this ?

@csandovalgt
Copy link

@Lyokone I too was able to replicate @Tom3652 's issue, and was able to fix it by changing the header of /firebase_auth-4.7.1/ios/Classes/messages.g.m:3:8

From:

#import "messages.g.h"

To:

#import <firebase_auth/messages.g.h>

hi @joshuariveramnltech, where is this file located? I've been searching it but I'm not able to find it, would you please share where is located?

@Mounix99
Copy link

@csandovalgt Just try searching this #import "messages.g.h" over the files

@russellwheatley
Copy link
Member

I've created a PR here: #11472

@firebase firebase locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] Cannot run version 4.7.0 on iOS
8 participants