fix(core): auth Swift support requires FLTFirebaseCorePlugin
& messages
to be shared
#16774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been testing this on my own copy of FlutterFire. You can see all iterations of this here: russellwheatley/test-flutterfire@5e6f02c...88b09c9
Changes made
FLTFirebaseCorePlugin
to be shared which, in turn, requires the last remaining class (and header file) in core which ismessages.g.m
.Unfortunately - swift integration tests won't work until this is merged and release is cut which versions firebase core shared for SPM.
I used the dependency from my own FlutterFire version of this change to use for cloud_firestore example app, and it built successfully:
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?