Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Swift Package Manager support #16782

Merged
merged 25 commits into from
Dec 6, 2024
Merged

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 27, 2024

Description

Removed FIRStorageHandle and replaced it with its underlying type NSString as it seems missing with Swift builds for whatever reason.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Dec 2, 2024
@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Dec 5, 2024
@russellwheatley russellwheatley marked this pull request as ready for review December 6, 2024 12:57
@russellwheatley russellwheatley merged commit b5993ae into main Dec 6, 2024
30 checks passed
@russellwheatley russellwheatley deleted the storage-spm branch December 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants