Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_messaging] Added dynamic firebase api configuration #2098

Closed

Conversation

devtronic
Copy link

Description

This PR extends the firebase_messaging plugin to provide the Firebase configuration at runtime instead of using the google-service.json / GoogleService-Info.plist

Detailed changes:
FirebaseMessagingPlugin.java:

  • Moved FirebaseApp.initializeApp inside the onMethodCall method in the "configure" branch
  • Checking if call.arguments is provided and it is an instance of Map.
    • If true create a FirebaseOptions object from the map and use it.
    • Otherwise initialize Firebase as before

FLTFirebaseMessagingPlugin.m:

  • Moved [FIRApp configure] etc. inside the handleMethodCall method in the "configure" branch.
  • Checking if call.arguments is provided and it is an instance of NSDictionary.
    • If true create a FIROptions object and init it with the googleAppId and gcmSenderId and pass it to [FIRApp configureWithOptions:options] to configure Firebase
    • Otherwise initialize Firebase as before

firebase_messaging.dart:

  • Added the FirebaseOptions class, which represents the configuration
  • Invoke the "configure" channel method with the options (if they are not null)

firebase_messaging_test.dart:

  • Added a test for the new method

README.md:

  • Added the "Advanced usage" section

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Changes:
`FirebaseMessagingPlugin.java`:
- Moved `FirebaseApp.initializeApp` inside the `onMethodCall` method in the "configure" branch
- Checking if `call.arguments` is provided and it is an instance of `Map`.
  - If true create a FirebaseOptions object from the map and use it.
  - Otherwise initialize Firebase as before

`FLTFirebaseMessagingPlugin.m`:
- Moved `[FIRApp configure]` etc. inside the `handleMethodCall` method in the "configure" branch.
- Checking if `call.arguments` is provided and it is an instance of `NSDictionary`.
  - If true create a `FIROptions` object and init it with the googleAppId and gcmSenderId and pass it to `[FIRApp configureWithOptions:options]` to configure Firebase
  - Otherwise initialize Firebase as before

`firebase_messaging.dart`:
- Added the `FirebaseOptions` class, which represents the configuration
- Invoke the "configure" channel method with the options (if they are not null)

`firebase_messaging_test.dart`:
- Added a test for the new method

`README.md`:
- Added the "Advanced usage" section
@devtronic
Copy link
Author

Any news on this?

@Salakar Salakar closed this in #4012 Nov 3, 2020
@firebase firebase locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants