[firebase_messaging] fix onLaunch being called again when resuming an application from Recents screen #3154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Android, there is an issue where it is possible for the
onLaunch
callback to be invoked multiple times. One way to produce this isonLaunch
should be calledonLaunch
is called againThis is happening as when the application starts up again, it will call
configure
method that will in turn process the intent. However, when processing the intent it should check to make sure that the app isn't launched via the Recents screen. This PR as this guard in to prevent the issue from happening.Note: for some reason, pub is failing to resolve the dependencies (didn't happen in the past) so I cannot try to out properly but had to a similar fix for my own plugin for local notifications. This is why I haven't ticked the box that the analyzer doesn't report any problems
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?