Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud_firestore] Improve reliability of includeMetadataChanges integration test #32

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Aug 26, 2019

I have a theory about why this test is timing out on CI, although I can't reproduce it locally -- if hasPendingWrites and isFromCache update at the same time, the test could fail.

@collinjackson collinjackson requested a review from kroikie as a code owner August 26, 2019 04:01
@collinjackson collinjackson changed the title Improve reliability of includeMetadataChanges integration test [cloud_firestore] Improve reliability of includeMetadataChanges integration test Aug 26, 2019
@kroikie kroikie merged commit d95af8f into firebase:master Aug 30, 2019
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants