feat(firebase_messaging): Support for multiple senderId (Android) #3936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the multiple senderId features as described in the offical doc.
senderId
inFirebaseMessaging.configure()
,FirebaseMessaging.getToken()
andFirebaseMessaging.deleteInstanceID()
FirebaseMessagingPlugin
to handle the changes.This requires maintainers input
I don't believe this PR is ready as-is.
I identified two issues:
senderId
yet). I'm not very fluent with Objective-C, so any help would be appreciated :-)onTokenRefresh
is fired for all the token updates (primary and secondary). I didn't change this to keep the code retro-compatible.However, for completeness, it would be better to send the token and the senderId in
onTokenRefresh
, but this is a breaking change.Another option is to deprecate
onTokenRefresh
an create another method.What do you think ?
Related Issues
No issue found.
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?