Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal commit from flutter/plugins repo #4

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Aug 20, 2019

Description

Apparently I didn't actually get this PR in before the transfer. Adding it here.

Related Issues

Original PR: flutter/plugins#1925

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines requested a review from amirh as a code owner August 20, 2019 22:41
@amirh
Copy link
Contributor

amirh commented Aug 20, 2019

RSLGTM

@bparrishMines bparrishMines merged commit f1e60a5 into firebase:master Aug 22, 2019
@bparrishMines bparrishMines deleted the horizontal branch August 22, 2019 18:36
@Saraalr Saraalr mentioned this pull request Jun 26, 2020
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants