Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firebase_admob] exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 #45

Closed
wants to merge 1 commit into from
Closed

[firebase_admob] exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 #45

wants to merge 1 commit into from

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Aug 27, 2019 •
edited
Loading

Migrates flutter/plugins#1631

Author description: "AdView be placed with frame location under ios 11. But translatesAutoresizingMaskIntoConstraints has NO flag."

Fixes flutter/flutter#27457

@collinjackson collinjackson changed the title Migrates flutter/plugins#1631 [firebase_admob] exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 Aug 27, 2019
@collinjackson collinjackson mentioned this pull request Aug 27, 2019
Closed
13 tasks
bparrishMines
bparrishMines approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westy92 westy92 mentioned this pull request Oct 13, 2019
Closed
@exilonX exilonX mentioned this pull request Oct 16, 2019
Closed
This was referenced Oct 24, 2019
Closed
Closed
@amitverma-cf amitverma-cf mentioned this pull request Nov 18, 2019
Closed
@NickM-27 NickM-27 mentioned this pull request Dec 12, 2019
Closed
@yousaywhat yousaywhat mentioned this pull request Dec 23, 2019
Closed
@craigbennett1981 craigbennett1981 mentioned this pull request Jan 28, 2020
Closed
@inuyashaaa
Copy link

Any news?

@asharora asharora mentioned this pull request Feb 27, 2020
Closed
@igorantolic igorantolic mentioned this pull request Mar 11, 2020
Closed
@ClevercodeTech ClevercodeTech mentioned this pull request Mar 16, 2020
Closed
@peterkuch peterkuch mentioned this pull request Mar 22, 2020
Closed
@vineetpandit90 vineetpandit90 mentioned this pull request Apr 17, 2020
Closed
@navigui navigui mentioned this pull request Apr 30, 2020
Closed
@besidesordinary besidesordinary mentioned this pull request May 5, 2020
Closed
@momo1606 momo1606 mentioned this pull request Jun 2, 2020
Closed
@MassiveSuccess MassiveSuccess mentioned this pull request Jun 7, 2020
Closed
@kroikie
Copy link
Collaborator

kroikie commented Jun 30, 2020

AdMob refactor is coming so closing this:
#2521

@kroikie kroikie closed this Jun 30, 2020
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase_admob plugin displays smart banner at top instead of bottom
4 participants
@collinjackson @inuyashaaa @kroikie @bparrishMines