Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_auth): Update documentation for currentUser property to make expectations clearer. #7843

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

keithshep
Copy link
Contributor

Description

I found the current comment for the currentUser getter to be a bit misleading so I hope this modification is a useful change. For more background see: https://stackoverflow.com/q/70655326/160015

Related Issues

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

I found the current comment to be a bit misleading so I hope this modification is a useful change. For background see: https://stackoverflow.com/q/70655326/160015
@keithshep keithshep changed the title an attempt to clarify currentUser documentation docs: an attempt to clarify currentUser documentation Jan 11, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley changed the title docs: an attempt to clarify currentUser documentation docs(firebase_auth): Update documentation for currentUser property to make expectations clearer. Feb 10, 2022
@russellwheatley russellwheatley merged commit 59bb47c into firebase:master Feb 10, 2022
@firebase firebase locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants