feat(ui): add firebase_ui_auth and oauth providers #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after #9340 |
This was
linked to
issues
Aug 11, 2022
Closed
12 tasks
Lyokone
approved these changes
Aug 18, 2022
packages/firebase_ui_auth/doc/providers/universal-email-sign-in.md
Outdated
Show resolved
Hide resolved
|
Was this PR created after merging different PR into a branch? I feel like it could gain in readability if it was separated into several commits |
russellwheatley
requested changes
Aug 18, 2022
packages/firebase_ui_auth/doc/providers/universal-email-sign-in.md
Outdated
Show resolved
Hide resolved
packages/firebase_ui_auth/doc/providers/universal-email-sign-in.md
Outdated
Show resolved
Hide resolved
lesnitsky
force-pushed
the
ui/auth
branch
2 times, most recently
from
b3ca195
to
30b5e48
Compare
This was
linked to
issues
Sep 16, 2022
Closed
Lyokone
approved these changes
Oct 13, 2022
pr-Mais
approved these changes
Oct 14, 2022
russellwheatley
requested changes
Oct 14, 2022
Comment on lines
+1
to
+5
| ## 1.0.0-dev.0 | ||
|
|
||
| - Bump "firebase_ui_auth" to `1.0.0-dev.0`. | ||
|
|
||
| ## 0.0.1 |
There was a problem hiding this comment.
I can't remember now, but do we need this? I just ran melos version and it produced another version:
version - 1.0.0-dev.1 🤔
There was a problem hiding this comment.
I'm not sure how this works either. We've put this manually for the dev release.
Next release should be without -dev.1 postfix, but rather regular 1.0.0 version.
I believe this should be done with --graduate.
As for actual changelog – it'd just mention a stable release and point to the migration guide in docs section.
packages/firebase_ui_auth/doc/providers/universal-email-sign-in.md
Outdated
Show resolved
Hide resolved
packages/firebase_ui_auth/example/test_driver/phone_verification_test.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Oct 17, 2022
russellwheatley
approved these changes
Oct 17, 2022
This was referenced Oct 17, 2022
This was referenced Oct 21, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title
Related Issues
Closes #8016, #8091, #9546, #9304, #9379, #8384, #8440, #8497, #8555, #8683, #8788, #8936, #8941, #9325, #8396
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?