Include model in options for executable prompts #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
reviewed
Oct 30, 2024
MichaelDoyle
force-pushed
the
executable-prompt-model
branch
from
6ad272d to
b39768a
Compare
|
Updated per @pavelgj and added a bit more color to the comments in the code to describe more clearly what is happening. |
maxl0rd
approved these changes
Oct 30, 2024
MichaelDoyle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrapping prompt actions as ExecutablePrompt, we need to include the model in the options. This is because the PromptAction returns GenerateRequest, which in turn does not actually include model. This is particularly a problem for dotprompt files.
Checklist (if applicable):
cc @pavelgj
Fixes #1119