Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: firebase documentation after 0.9 upgrade #1305

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

xavidop
Copy link
Contributor

@xavidop xavidop commented Nov 15, 2024

This PR updates the docs after upgrading to 0.9.0:

  1. Since the firebase emulator and the genkit UI uses by default the same port (4000), it is better to start first the genkit UI and then the firebase emulator. The firebase emulator autodetect that the port 4000 is in use and uses another one.
  2. Added the npm command provided by the firebase template npm run genkit:start
  3. fixes this visualization problem: https://firebase.google.com/docs/genkit/monitoring#trace_storage_and_developer_ui

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@xavidop xavidop changed the title docs: fix firebase documentation after 0.9 upgrade fix: firebase documentation after 0.9 upgrade and structured output vertexai Nov 15, 2024
@MichaelDoyle
Copy link
Member

@xavidop this is awesome. would you mind splitting the code changes from the docs changes (i.e. 2 PRs), since they are not related? I think we'll have an easier time getting the right folks to review that way.

Mike D

@xavidop xavidop changed the title fix: firebase documentation after 0.9 upgrade and structured output vertexai fix: firebase documentation after 0.9 upgrade Nov 15, 2024
@xavidop
Copy link
Contributor Author

xavidop commented Nov 15, 2024

@xavidop this is awesome. would you mind splitting the code changes from the docs changes (i.e. 2 PRs), since they are not related? I think we'll have an easier time getting the right folks to review that way.

Mike D

@MichaelDoyle done!

docs/firebase.md Outdated Show resolved Hide resolved
@pavelgj pavelgj merged commit 1ecf199 into firebase:main Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants