Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting root span status explicitly #1449

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Setting root span status explicitly #1449

merged 1 commit into from
Dec 3, 2024

Conversation

maxl0rd
Copy link
Contributor

@maxl0rd maxl0rd commented Dec 3, 2024

Enable unambiguous queries for traces with root successes or failures

@maxl0rd maxl0rd requested a review from schnecle December 3, 2024 18:25
Copy link
Contributor

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@maxl0rd maxl0rd merged commit f91b098 into main Dec 3, 2024
4 checks passed
@maxl0rd maxl0rd deleted the ml_root_state branch December 3, 2024 20:37
@pavelgj
Copy link
Collaborator

pavelgj commented Dec 5, 2024

please follow https://www.conventionalcommits.org/en/v1.0.0/

this PR title should've been: fix(js/plugins/google-cloud): setting root span status explicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants