Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go): Add ollama embeddings support #841

Merged
merged 9 commits into from
Sep 16, 2024
Merged

feat(go): Add ollama embeddings support #841

merged 9 commits into from
Sep 16, 2024

Conversation

huangjeff5
Copy link
Contributor

Checklist (if applicable):

  • [x ] Tested manually

@cabljac
Copy link
Contributor

cabljac commented Aug 30, 2024

Hey Jeff I added embeddings here - #751

@huangjeff5
Copy link
Contributor Author

Hey Jeff I added embeddings here - #751

Discussed offline; we will continue integrating directly with REST API so that we don't add an unnecessary dependency (SDK).

@huangjeff5 huangjeff5 requested a review from pavelgj September 3, 2024 17:24
pavelgj
pavelgj reviewed Sep 5, 2024
View reviewed changes
go/plugins/ollama/embed.go Outdated Show resolved Hide resolved
@huangjeff5 huangjeff5 requested a review from pavelgj September 13, 2024 15:56
@huangjeff5 huangjeff5 merged commit b86533a into main Sep 16, 2024
5 checks passed
@huangjeff5 huangjeff5 deleted the jh-ollama-embedder-go branch September 16, 2024 16:35
@huangjeff5 huangjeff5 mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

@apascal07 apascal07 Awaiting requested review from apascal07

@ssbushi ssbushi Awaiting requested review from ssbushi

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangjeff5 @cabljac @pavelgj