Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Make raisedEvent method public #76

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Make raisedEvent method public #76

merged 1 commit into from
Nov 1, 2017

Conversation

adauvalter
Copy link
Contributor

@adauvalter adauvalter commented Sep 12, 2017

We extended GeoQuery class raising events from it. Right now it's impossible to due to access modifier.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@adauvalter
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@samtstern
Copy link
Contributor

@adauvalter can you explain a little more about your use case here?

@adauvalter
Copy link
Contributor Author

@samtstern the idea is, that we use a kind of cache on our side, to determine added, changed, removed points, because they're moving. Depends on the state we fire those events like geoFire.raiseEvent { listener.objectMoved(it) }

@vanniktech
Copy link
Contributor

vanniktech commented Sep 15, 2017

Our use case is also used here where the raiseEvent is called. We adjusted this class a bit to our needs and now want to manually fire events.

@vanniktech
Copy link
Contributor

Just wanted to know whether there's an update on this. This is currently the only function that we need that is not public.

If this would get merged and a new release would be published, we could get rid of our internal fork.

In case you need any further explanation about the use case, let me know @samtstern

@samtstern
Copy link
Contributor

@adauvalter @vanniktech as discussed (in person) at the Firebase Dev Summit, I am happy to merge this PR to make your use case easier. I'll do it now!

I'd also love to hear more (if you have time) about the motivation for the PR and the ways you're customizing GeoFire. Making this method public is sort of a hack, maybe a refactor would serve your needs better.

@samtstern samtstern merged commit bdda1c9 into firebase:master Nov 1, 2017
@samtstern
Copy link
Contributor

Release 2.1.3

@vanniktech
Copy link
Contributor

Thanks for getting this in. As discussed, I emailed you with some personal information about our project and the requirements. I'm happy to translate the outputs of our discussion into issues / PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants