-
Notifications
You must be signed in to change notification settings - Fork 271
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@adauvalter can you explain a little more about your use case here? |
@samtstern the idea is, that we use a kind of cache on our side, to determine added, changed, removed points, because they're moving. Depends on the state we fire those events like |
Our use case is also used here where the |
Just wanted to know whether there's an update on this. This is currently the only function that we need that is not public. If this would get merged and a new release would be published, we could get rid of our internal fork. In case you need any further explanation about the use case, let me know @samtstern |
@adauvalter @vanniktech as discussed (in person) at the Firebase Dev Summit, I am happy to merge this PR to make your use case easier. I'll do it now! I'd also love to hear more (if you have time) about the motivation for the PR and the ways you're customizing GeoFire. Making this method public is sort of a hack, maybe a refactor would serve your needs better. |
Release |
Thanks for getting this in. As discussed, I emailed you with some personal information about our project and the requirements. I'm happy to translate the outputs of our discussion into issues / PRs. |
We extended GeoQuery class raising events from it. Right now it's impossible to due to access modifier.