Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firebase\jwt namespace #59

Merged
merged 3 commits into from
Jul 9, 2015
Merged

Add firebase\jwt namespace #59

merged 3 commits into from
Jul 9, 2015

Conversation

Dashron
Copy link

@Dashron Dashron commented Jul 1, 2015

Puts the jwt class under the \Firebase\JWT namespace.

There is more discussion here: #52
I chose this namespace scheme to match another firebase php library: https://github.com/firebase/firebase-token-generator-php/tree/master/src

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Dashron
Copy link
Author

Dashron commented Jul 1, 2015

Waiting on approval from my employer before signing the CLA. Will update you when I have more info.

@AustP
Copy link

AustP commented Jul 8, 2015

@Dashron - Any update on this?

@Dashron
Copy link
Author

Dashron commented Jul 8, 2015

Waiting on the individual authorized to sign on behalf of the company (or however it was worded in the doc) to actually sign the CLA. Everything else has been set up.

@Dashron Dashron changed the title Add firespace\jwt namespace Add firebase\jwt namespace Jul 8, 2015
@Dashron
Copy link
Author

Dashron commented Jul 9, 2015

I've signed it on behalf of Vimeo.

@robertdimarco
Copy link

@Dashron Thank you for the contribution! I'll get a release cut with this and another upcoming change shortly.

robertdimarco added a commit that referenced this pull request Jul 9, 2015
Add firebase\jwt namespace
@robertdimarco robertdimarco merged commit 436e005 into firebase:master Jul 9, 2015
leoruhland added a commit to leoruhland/cakephp-api that referenced this pull request Dec 1, 2015
@mannutech
Copy link

Unable to find JWT class. Help to resolve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants