Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in support for late static binding #88

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Add in support for late static binding #88

merged 1 commit into from
Jun 28, 2016

Conversation

chappy84
Copy link

Enables developers to extend the class and override variables / methods if they so require.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@chappy84
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@robertdimarco
Copy link

@chappy84 Any chance you'd have time to take a peek at these merge conflicts? I'll merge asap after that; this looks good to me!

… and override variables / methods if they so require
@chappy84
Copy link
Author

@robertdimarco Should be all sorted now :)

@robertdimarco robertdimarco merged commit d425647 into firebase:master Jun 28, 2016
@chappy84 chappy84 deleted the lsb branch June 29, 2016 17:36
@chappy84
Copy link
Author

@robertdimarco Thanks for merging :)
I was wondering if there were plans to tag a new version so those using composer can start updating?

@robertdimarco
Copy link

@chappy84 Shipped! Thanks for all of your help on this release. =) 🚢

@chappy84
Copy link
Author

Thanks @robertdimarco, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants