Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linux CI #3

Merged
merged 3 commits into from
Nov 12, 2021
Merged

fix linux CI #3

merged 3 commits into from
Nov 12, 2021

Conversation

UnGast
Copy link
Contributor

@UnGast UnGast commented Oct 15, 2021

Description

CI fails on linux because Platform.initialize() is called in the testPlatformSetup() test case, which seems to require a video device.

possible fixes:

  • don't execute tests on linux (current solution)
  • add environment variable, read it in Package.swift and add a define to specifically exclude tests that require a video device
  • setup a virtual video device (quite a lot of configuration work probably, but doable (have already done it at some point))

Which solution to pick depends on how important the tests are to this project. Is there a real need to write detailed tests as I assume that SDL2 is already being tested?
If the answer is that there is a need the CI could run without tests until there is a significant amount of them.

Checklist

  • I've read the Contribution Guidelines
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (to the extent possible).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexpected benchmark regressions.
  • I've updated the documentation (if appropriate).

@ctreffs ctreffs added the ci-all label Oct 17, 2021
# Conflicts:
#	.github/workflows/ci-linux.yml
@UnGast UnGast requested a review from ctreffs as a code owner November 12, 2021 14:20
@ctreffs
Copy link
Member

ctreffs commented Nov 12, 2021

Let's keep the solution for this as is for now.

setup a virtual video device (quite a lot of configuration work probably, but doable (have already done it at some point))
will be done in the future

@ctreffs ctreffs enabled auto-merge (squash) November 12, 2021 14:21
@ctreffs
Copy link
Member

ctreffs commented Nov 12, 2021

Will close: #2

@ctreffs ctreffs merged commit d4f7920 into main Nov 12, 2021
@ctreffs ctreffs deleted the fix-linux-ci branch November 12, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants