Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clipboard handling #8

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Add Clipboard handling #8

merged 5 commits into from
Nov 10, 2021

Conversation

UnGast
Copy link
Contributor

@UnGast UnGast commented Nov 9, 2021

Description

Adds clipboard text handling for available platforms.

Documentation

SDL
Apple

Source Impact

Additions only.

Checklist

  • I've read the Contribution Guidelines
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (to the extent possible).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexpected benchmark regressions.
  • I've updated the documentation (if appropriate).

@UnGast UnGast requested a review from ctreffs as a code owner November 9, 2021 20:42
@UnGast
Copy link
Contributor Author

UnGast commented Nov 9, 2021

Currently implemented: getClipboardText() on Platform and SDLPlatform. Maybe the way Platform works can be changed => use Protocols instead of forwarding functions manually?

@ctreffs
Copy link
Member

ctreffs commented Nov 10, 2021

Currently implemented: getClipboardText() on Platform and SDLPlatform. Maybe the way Platform works can be changed => use Protocols instead of forwarding functions manually?

Funny I just had this requirement recently :-) Will have a look at it

@ctreffs ctreffs added the enhancement New feature or request label Nov 10, 2021
@ctreffs ctreffs changed the title add getClipboardText() Add Clipboard handling Nov 10, 2021
@ctreffs
Copy link
Member

ctreffs commented Nov 10, 2021

I've switched to a protocol based implementation, since this will provide more flexibility on other platforms.

@ctreffs ctreffs added the ci-all label Nov 10, 2021
@ctreffs ctreffs merged commit d4676a3 into main Nov 10, 2021
@ctreffs ctreffs deleted the clipboard branch November 10, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-all enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants