Feat/add trc20 support #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update globalAssets to include contract address for trc20 tokens
a0ngo
reviewed
Jan 15, 2025
Comment on lines
+182
to
+185
| if (asset.address && asset.protocol === 'TRX') { | ||
| (derivation as TRC20).setTokenAddress(asset.address); | ||
| (derivation as TRC20).setDecimals(asset.decimals); | ||
| (derivation as ERC20).setToAddress(toAddress); |
There was a problem hiding this comment.
You can optimize these multiple ifs, but it's ok for now
|
If that is the only scenario where decimals don't exist, this should either
be a full failure that is detected during tests or this should be a
terminal error that will stop the transaction generation process.
…On Wed, Jan 15, 2025 at 2:48 PM T0m3r ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/recovery-utility/renderer/lib/wallets/TRC20/index.ts
<#118 (comment)>:
> + const decimals = extraParams?.get('d');
+ if (!decimals) {
+ this.utilityLogger.error('TRC20: Decimals not set');
+ }
Then globalAssets needs to be updated to include the decimals.
I don't see a case where the token will not have decimals at all, no?
—
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZJ34J3HBN74UHCEU2U77332KZKKDAVCNFSM6AAAAABVCPR552VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJSGY2DSOJRGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
a0ngo
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.