Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: nuke setup.cfg until we can full switch from setup.py to setup.cfg #29

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Dec 6, 2021

Resolves #28

Description

Working adapter for users takes precedence of pre-commit hooks. I can confirm that I can now install the package correctly.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have updated CHANGELOG.md and added information about my change.
  • If this PR requires a new PyPI release I have bumped the version number.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • I have verified that this PR contains only code changes relevant to this PR.

Copy link
Contributor

@kevinmarr kevinmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dataders dataders merged commit 9b68054 into main Dec 7, 2021
@ericf-firebolt ericf-firebolt deleted the hotfix_install_failure branch December 29, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in installation due to setup.cfg misconfiguration
2 participants