fix: explicitly close ctmap on every iteration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-ag
reviewed
Jun 24, 2024
| @@ -77,8 +76,12 @@ func listRecords(maps []interface{}, clockSource ClockSource, filter EntriesFilt | |||
| } | |||
| } | |||
| if err = m.DumpWithCallback(cb); err != nil { | |||
| m.Close() | |||
There was a problem hiding this comment.
Consider moving cb := definition outside of for-loop as it does not appear to depend on m (therefore no need to create a new function every iteration). And moving whatever remains into a separate function that could retain defer m.Close().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly close m after every iteration, because
defer m.Close()will only close it when the function returns. This means as long as the loop is running, the callstack increases.Other notes to the reviewer
I aim to close a potential memory leak