Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old/unused settings from FireboltConnectionTest #466

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

moshap-firebolt
Copy link
Contributor

There were old settings set on URL for JDBC testing with localy running Firebolt instance. In order to remove these unused settings from Firebolt codebase - we need to clean them from here first.

@moshap-firebolt moshap-firebolt requested a review from a team as a code owner October 18, 2024 17:06
@ptiurin
Copy link
Contributor

ptiurin commented Oct 21, 2024

CI's failing due to the additional restrictions on PRs from forks. Tested from a branch and the build's succeeding.

@ptiurin ptiurin merged commit ed3af1e into firebolt-db:master Oct 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants