Fir 37710 jdbc validate connection against system engine #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
approved these changes
Oct 30, 2024
| } | ||
| var propertiesBuilder = fireboltProperties.toBuilder().runtimeAdditionalProperties(runtimeProperties); | ||
| if (getSessionProperties().isValidateOnSystemEngine()) { | ||
| propertiesBuilder.compress(false).engine(null).systemEngine(true); |
There was a problem hiding this comment.
Why do we have compress(false) defined here? Is there a special behaviour on system engine?
There was a problem hiding this comment.
For system engine we automatically disable compress in JDBC.
https://github.com/firebolt-db/jdbc/blob/master/src/main/java/com/firebolt/jdbc/connection/settings/FireboltProperties.java#L97
I'm not sure of the reasons, all that I can say is that system engine doesn't work with compres as tests have shown. We receive an expected end of stream, and I failed ot understand the reason behind it
src/main/java/com/firebolt/jdbc/connection/settings/FireboltSessionProperty.java
Outdated
Show resolved
Hide resolved
stepansergeevitch
deleted the
FIR-37710-jdbc-validate-connection-against-system-engine
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for isValid method:
validate_on_system_engine, which forces a connection to run isValid on a system engine even if it's connected to a user engine