Upgrade gradle and improve release workflow #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-dispa
force-pushed
the
feature/gradle-upgrade
branch
14 times, most recently
from
8895b61 to
23c5ee8
Compare
aymeric-dispa
force-pushed
the
feature/gradle-upgrade
branch
from
23c5ee8 to
8a92db4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
aymeric-dispa
changed the title
ptiurin
approved these changes
Aug 12, 2022
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| zipStorePath=wrapper/dists |
There was a problem hiding this comment.
not an issue, but it's generally a good practice to leave the newline in. Makes parsing easier.
Comment on lines
+208
to
+213
| # Stop when "xargs" is not available. | ||
| if ! command -v xargs >/dev/null 2>&1 | ||
| then | ||
| die "xargs is not available" | ||
| fi | ||
|
|
There was a problem hiding this comment.
When does this happen? I thought xargs comes by default with most unix systems.
There was a problem hiding this comment.
This file was generated when I ran command to upgrade gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update relelease process: