Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dmenu option to wofi invocation #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hexbioc
Copy link

@hexbioc hexbioc commented Jun 5, 2024

On Wayland, with wofi, the script fails with a cryptic error:

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_get_qdata: assertion 'G_IS_OBJECT (object)' failed

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_set_qdata_full: assertion 'G_IS_OBJECT (object)' failed

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_set_qdata_full: assertion 'G_IS_OBJECT (object)' failed

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

Turns out it is due to the failure in launching wofi, as it requires the --dmenu option to operate in dmenu mode.

This PR adds the same.

PS: Please let me know if you'd like me to create an issue first!

@firecat53
Copy link
Owner

firecat53 commented Jun 5, 2024

You can add --dmenu to your dmenu_command configuration, for example (see README): dmenu_command = wofi --dmenu

I would like to make nmdm a bit smarter and generalize support for each launcher so you don't have to configure common items like --dmenu. Unfortunately they all have different flags.

I'm going to leave this open as a reminder to myself to work on streamlining launcher support. Thanks for the contribution and the interest!

@winkelnp
Copy link

winkelnp commented Oct 27, 2024

I'm not sure those error messages have anything to do with running wofi without --dmenu as I also seem to get those when running with the option (in config.ini or with the given patch). They only appear when exiting and don't seem to be affecting usage though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants