Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable project file variable file path and support dotenv format #1355

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Oct 2, 2024

resolves #1332

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@ANGkeith ANGkeith force-pushed the feat/make-project-file-variable-file-configurable branch 3 times, most recently from 7d33674 to fff7a61 Compare October 3, 2024 02:07
@ANGkeith ANGkeith marked this pull request as draft October 4, 2024 01:54
@ANGkeith ANGkeith force-pushed the feat/make-project-file-variable-file-configurable branch 2 times, most recently from df19bb2 to 3101f0d Compare October 4, 2024 04:42
@ANGkeith ANGkeith marked this pull request as ready for review October 4, 2024 04:42
@ANGkeith ANGkeith force-pushed the feat/make-project-file-variable-file-configurable branch from a8add37 to 26a9dd8 Compare October 4, 2024 06:28
@ANGkeith ANGkeith marked this pull request as draft October 4, 2024 06:45
@ANGkeith ANGkeith force-pushed the feat/make-project-file-variable-file-configurable branch from 0a3a28a to 815edaf Compare October 4, 2024 07:21
@ANGkeith ANGkeith changed the title feat: make project file variable file configurable feat: customizable project file variable file path and support dotenv format Oct 4, 2024
@ANGkeith ANGkeith marked this pull request as ready for review October 4, 2024 07:27
@ANGkeith ANGkeith force-pushed the feat/make-project-file-variable-file-configurable branch from 1eddd85 to 5dd6057 Compare October 4, 2024 07:34
@firecow
Copy link
Owner

firecow commented Oct 7, 2024

I don't like this complexity...
It's a different file format, it should be a different command line option.

@ANGkeith ANGkeith marked this pull request as draft October 8, 2024 01:47
@ANGkeith
Copy link
Collaborator Author

ANGkeith commented Oct 9, 2024

I don't like this complexity...
It's a different file format, it should be a different command line option.

I don't quite understand your perspective on this.

The way I see it is:
it's different file format, but it serves the same purpose (ie. setting variables for the executor)

Taking eslint as an example:
It only has a single --config option, regardless of the supported format. They don’t introduce separate options for each format (e.g., --json-config, --mjs-config, etc.).

@firecow
Copy link
Owner

firecow commented Oct 10, 2024

I don't like this complexity...
It's a different file format, it should be a different command line option.

I don't quite understand your perspective on this.

The way I see it is: it's different file format, but it serves the same purpose (ie. setting variables for the executor)

Taking eslint as an example: It only has a single --config option, regardless of the supported format. They don’t introduce separate options for each format (e.g., --json-config, --mjs-config, etc.).

You convinced me with the eslint example. Get it out of draft, and lets merge it 👍

@ANGkeith
Copy link
Collaborator Author

nice!

let's get the big mr #1331 in first.

@ANGkeith ANGkeith force-pushed the feat/make-project-file-variable-file-configurable branch from e90bd3a to 2901e8e Compare October 11, 2024 02:22
@ANGkeith ANGkeith marked this pull request as ready for review October 11, 2024 02:22
Copy link

sonarcloud bot commented Oct 11, 2024

@ANGkeith ANGkeith added 5.x.x and removed 5.x.x labels Oct 11, 2024
@firecow firecow merged commit 32176c6 into master Oct 11, 2024
10 checks passed
@firecow firecow deleted the feat/make-project-file-variable-file-configurable branch October 11, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --env-file-to-variables cli option
2 participants