Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send to copyDone when err == nil #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Send to copyDone when err == nil #767

wants to merge 1 commit into from

Commits on Sep 21, 2023

  1. Send to copyDone when err == nil 

    The ioproxy helps copy container logs from the normal container fifos to
the firecracker uvm's vsock. The copying happens in a go-routine and
when complete, it send a notification over the `copyDone` channel to
signal to the agent/runtime to cleanup the ioproxy.

This change fixes a bug where, if the iopoxy copy finished without an
error (i.e. `io.CopyBuffer` got an `EOF` from the read end), the
`copyDone` channel was not notified leaving the ioproxy connected to the
vsock, but not the container. This change always notifies `copyDone`
when the copy finishes.

Signed-off-by: Kern Walster <walster@amazon.com>
    @Kern--
    Kern-- committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9626cbc View commit details
    Browse the repository at this point in the history