-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rebase-snap
to snapshot-editor
#4075
Merged
ShadowCurse
merged 4 commits into
firecracker-microvm:main
from
ShadowCurse:snapshot_editor_rebase_snap
Sep 1, 2023
Merged
Adding rebase-snap
to snapshot-editor
#4075
ShadowCurse
merged 4 commits into
firecracker-microvm:main
from
ShadowCurse:snapshot_editor_rebase_snap
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4075 +/- ##
==========================================
- Coverage 82.38% 82.35% -0.03%
==========================================
Files 224 225 +1
Lines 28415 28466 +51
==========================================
+ Hits 23410 23444 +34
- Misses 5005 5022 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6842e33
to
14f1161
Compare
4c88305
to
55f0d10
Compare
kalyazin
reviewed
Aug 31, 2023
8b4d0d0
to
9c9c471
Compare
kalyazin
previously approved these changes
Aug 31, 2023
dbcf0f0
to
12e57f5
Compare
wearyzen
previously approved these changes
Sep 1, 2023
12e57f5
to
229cc57
Compare
wearyzen
approved these changes
Sep 1, 2023
kalyazin
approved these changes
Sep 1, 2023
Added `rebase-snap` functionality into `snapshot-editor`. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Added `snapshot-editor` to the `test_5_snapshots` test as a replacement for `rebase-snap`. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Added info about new `snapshot-editor` function. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Updated changelog with additional features of the `snapshot-editor`. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
229cc57
to
9cf8713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Enhancement
Indicates new feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
rebase-snap
function to thesnapshot-editor
tool.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
CHANGELOG.md
.TODO
s link to an issue.rust-vmm
.