Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass through no-API shutdown exit code (main) #4178

Conversation

JonathanWoollett-Light
Copy link
Contributor

Changes

Pass through no-API shutdown exit code

Reason

#4176

Without passing through the exit code a non-zero exit code was returned on a successful no-API shutdown.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light added Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Oct 16, 2023
@JonathanWoollett-Light JonathanWoollett-Light changed the title fix: Pass through no-API shutdown exit code fix: Pass through no-API shutdown exit code (main) Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (00524a7) 83.03% compared to head (2db88a4) 83.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4178      +/-   ##
==========================================
- Coverage   83.03%   83.02%   -0.01%     
==========================================
  Files         222      222              
  Lines       28634    28635       +1     
==========================================
  Hits        23775    23775              
- Misses       4859     4860       +1     
Flag Coverage Δ
4.14-c7g.metal 78.59% <0.00%> (-0.01%) ⬇️
4.14-m5d.metal 80.37% <0.00%> (-0.01%) ⬇️
4.14-m6a.metal 79.52% <0.00%> (+0.03%) ⬆️
4.14-m6g.metal 78.59% <0.00%> (-0.01%) ⬇️
4.14-m6i.metal 80.37% <0.00%> (-0.01%) ⬇️
5.10-c7g.metal 81.50% <0.00%> (-0.01%) ⬇️
5.10-m5d.metal 83.05% <0.00%> (-0.01%) ⬇️
5.10-m6a.metal 82.29% <0.00%> (-0.01%) ⬇️
5.10-m6g.metal 81.50% <0.00%> (-0.01%) ⬇️
5.10-m6i.metal 83.04% <0.00%> (-0.01%) ⬇️
6.1-c7g.metal 81.50% <0.00%> (-0.01%) ⬇️
6.1-m5d.metal 83.05% <0.00%> (-0.01%) ⬇️
6.1-m6a.metal 82.29% <0.00%> (-0.01%) ⬇️
6.1-m6g.metal 81.50% <0.00%> (-0.01%) ⬇️
6.1-m6i.metal 83.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/firecracker/src/main.rs 0.22% <0.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonathanWoollett-Light JonathanWoollett-Light force-pushed the exit_code_pass_through branch 13 times, most recently from cc5d228 to aa18f7d Compare October 17, 2023 18:36
Without passing through the exit code a non-zero exit code was returned
on a successful no-API shutdown.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
@wearyzen wearyzen merged commit 8f4f0a0 into firecracker-microvm:main Oct 18, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants