Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor error propagation (1.5) #4191

Conversation

JonathanWoollett-Light
Copy link
Contributor

Changes

Refactors error propagation to avoid logging and printing misleading error messages.

Reason

See above.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light changed the title fix: Refactor error propagation fix: Refactor error propagation (1.5) Oct 20, 2023
Refactors error propagation to avoid logging and printing misleading
error messages.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e6fb1f3) 82.98% compared to head (7edaff2) 82.96%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           firecracker-v1.5    #4191      +/-   ##
====================================================
- Coverage             82.98%   82.96%   -0.03%     
====================================================
  Files                   223      223              
  Lines                 28449    28456       +7     
====================================================
  Hits                  23609    23609              
- Misses                 4840     4847       +7     
Flag Coverage Δ
4.14-c7g.metal 78.50% <0.00%> (-0.03%) ⬇️
4.14-m5d.metal 80.30% <0.00%> (-0.04%) ⬇️
4.14-m6a.metal 79.43% <0.00%> (-0.03%) ⬇️
4.14-m6g.metal 78.50% <0.00%> (-0.03%) ⬇️
4.14-m6i.metal 80.29% <0.00%> (-0.03%) ⬇️
5.10-c7g.metal 81.42% <0.00%> (-0.03%) ⬇️
5.10-m5d.metal 82.98% <0.00%> (-0.03%) ⬇️
5.10-m6a.metal 82.21% <0.00%> (-0.03%) ⬇️
5.10-m6g.metal 81.42% <0.00%> (-0.03%) ⬇️
5.10-m6i.metal 82.96% <0.00%> (-0.03%) ⬇️
6.1-c7g.metal 81.42% <0.00%> (-0.03%) ⬇️
6.1-m5d.metal 82.98% <0.00%> (-0.04%) ⬇️
6.1-m6a.metal 82.21% <0.00%> (-0.03%) ⬇️
6.1-m6g.metal 81.42% <0.00%> (-0.03%) ⬇️
6.1-m6i.metal 82.96% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/firecracker/src/main.rs 0.22% <0.00%> (-0.01%) ⬇️
src/firecracker/src/api_server_adapter.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat merged commit 92bed78 into firecracker-microvm:firecracker-v1.5 Oct 20, 2023
5 of 7 checks passed
@pb8o pb8o mentioned this pull request Nov 28, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants