-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print MicrovmState from vmstate file of snapshot #4205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
==========================================
- Coverage 82.96% 82.86% -0.10%
==========================================
Files 222 222
Lines 28299 28330 +31
==========================================
Hits 23477 23477
- Misses 4822 4853 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
998846a
to
420552e
Compare
0582e67
to
8db714f
Compare
ShadowCurse
reviewed
Oct 30, 2023
0ed8c40
to
4b81147
Compare
ShadowCurse
reviewed
Oct 31, 2023
4b81147
to
7941118
Compare
5b9af6b
to
7a85ec4
Compare
ShadowCurse
previously approved these changes
Oct 31, 2023
kalyazin
reviewed
Nov 1, 2023
It looks like we may need a changelog entry for this. |
7a85ec4
to
3b6c559
Compare
ShadowCurse
previously approved these changes
Nov 1, 2023
0c126ff
to
75f8b77
Compare
kalyazin
previously approved these changes
Nov 1, 2023
Sort VcpuState.saved_msrs by 1st the nmsrs & 2nd by pad field so that we get a better diff of MicrovmState of 2 or more snapshots. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add subcommand in InfoVmStateSubCommand to print the VmState. The output of this command can be used to diff between 2 different snapshot files. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add steps on how to use the new subcommand to print vmstate in human readable format. Improve readability of subcommand sections. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Since x86 now has vcpu states printable, make info_vcpu_states available on x86 as well. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Update CHANGELOG to publish addition of new command to print MicrovmState from vmstate snapshot files and that vcpu-states is now available on X86_64 as well. Signed-off-by: Sudan Landge <sudanl@amazon.com>
75f8b77
to
74519f9
Compare
kalyazin
approved these changes
Nov 1, 2023
ShadowCurse
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add subcommand in InfoVmStateSubCommand to print the VmState.
Reason
Printing MicrovmState from vmstate file of snapshot makes snapshot comparison easier to read.
The command can be used as below on 2 different snapshot files and the output when compared using any diff tool (e.g. vimdiff) is lot easier to read.
An example run on aarch64
Output on x86_64 is too big so not posting it here.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md
.[ ] NewTODO
s link to an issue.[ ] Commits meet contribution quality standards.rust-vmm
.