Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked rebase-snap as deprecated #4209

Merged

Conversation

ShadowCurse
Copy link
Contributor

Changes

Marked rebase-snap as deprecated in favour of snapshot-editor

Reason

We have snapshot-editor which is a newer tool with more options.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse self-assigned this Oct 31, 2023
@ShadowCurse ShadowCurse force-pushed the deprecate_snap_rebase branch 3 times, most recently from 752a731 to ea735ea Compare October 31, 2023 13:26
kalyazin
kalyazin previously approved these changes Oct 31, 2023
@ShadowCurse ShadowCurse marked this pull request as ready for review October 31, 2023 13:28
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation labels Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d915fef) 82.93% compared to head (c242b2c) 82.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4209      +/-   ##
==========================================
- Coverage   82.93%   82.92%   -0.02%     
==========================================
  Files         221      221              
  Lines       28231    28235       +4     
==========================================
  Hits        23414    23414              
- Misses       4817     4821       +4     
Flag Coverage Δ
4.14-c7g.metal 78.33% <0.00%> (-0.02%) ⬇️
4.14-m5d.metal 80.26% <0.00%> (-0.03%) ⬇️
4.14-m6a.metal 79.40% <0.00%> (-0.02%) ⬇️
4.14-m6g.metal 78.33% <0.00%> (-0.02%) ⬇️
4.14-m6i.metal 80.26% <0.00%> (-0.02%) ⬇️
5.10-c7g.metal 81.29% <0.00%> (-0.02%) ⬇️
5.10-m5d.metal 82.99% <0.00%> (-0.01%) ⬇️
5.10-m6a.metal 82.21% <0.00%> (-0.02%) ⬇️
5.10-m6g.metal 81.29% <0.00%> (-0.02%) ⬇️
5.10-m6i.metal 82.97% <0.00%> (-0.01%) ⬇️
6.1-c7g.metal 81.29% <0.00%> (-0.02%) ⬇️
6.1-m5d.metal 82.99% <0.00%> (-0.01%) ⬇️
6.1-m6a.metal 82.21% <0.00%> (-0.02%) ⬇️
6.1-m6g.metal 81.29% <0.00%> (-0.02%) ⬇️
6.1-m6i.metal 82.97% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/rebase-snap/src/main.rs 59.37% <0.00%> (-2.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
bchalios
bchalios previously approved these changes Oct 31, 2023
zulinx86
zulinx86 previously approved these changes Oct 31, 2023
Marked `rebase-snap` as deprecated in favour of `snapshot-editor`

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
@ShadowCurse ShadowCurse merged commit ded9038 into firecracker-microvm:main Oct 31, 2023
6 of 7 checks passed
@ShadowCurse ShadowCurse deleted the deprecate_snap_rebase branch October 31, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants