Aggregate latency metrics for vm exits handling IO #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4346 +/- ##
==========================================
+ Coverage 81.55% 81.57% +0.02%
==========================================
Files 240 240
Lines 29370 29409 +39
==========================================
+ Hits 23952 23990 +38
- Misses 5418 5419 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wearyzen
added
the
Status: Awaiting review
pb8o
reviewed
Dec 29, 2023
wearyzen
force-pushed
the
kvm_metrics
branch
2 times, most recently
from
49d22ef
to
6aeb5f9
Compare
wearyzen
force-pushed
the
kvm_metrics
branch
4 times, most recently
from
96a2ae1
to
c57e5a9
Compare
ShadowCurse
reviewed
Jan 2, 2024
roypat
reviewed
Jan 2, 2024
wearyzen
force-pushed
the
kvm_metrics
branch
3 times, most recently
from
1509b2c
to
74d2f98
Compare
Firecracker till now had a "group_metrics:key_metrics:value" pair and with new metrics for kvm exits this relation changes to "group_metrics: key_metrics:sub_key_metrics:value". Update the flush_fc_metrics_to_cw() to be able to parse this and make it future proof to support further sub_key_metrics levels. Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
force-pushed
the
kvm_metrics
branch
2 times, most recently
from
2efa813
to
2ef448a
Compare
ShadowCurse
previously approved these changes
Jan 3, 2024
wearyzen
force-pushed
the
kvm_metrics
branch
3 times, most recently
from
0535e6a
to
a53bd1c
Compare
wearyzen
changed the title
added 2 commits
January 3, 2024 18:59
Add a new struct to record aggregate (min/max/sum) of time difference as a metric. Use the Aggregate metrics structure to record aggregate of IO and MMIO vm exits. With this change Firecracker now emits new metrics corresponding to min/max/sum for kvm exits handling IO. Signed-off-by: Sudan Landge <sudanl@amazon.com>
While running AB perf tests with new kvm_metrics enabled a new sock intermittent ci issues was found and ping_latency showed a regression. vsock iperf test fails intermittently with error: `/tmp/iperf3-vsock: Text file busy` ping_latency regression was not consistent and fixed on retry. Since the only variable here is collecting metrics adjusting the point of collection for final metrics for performance tests fixes both the issues. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Update CHANGELOG to publish that Firecracker now emits new metrics. Also, document using a pseudo code how to extract metrics units from Firecracker metrics names. Signed-off-by: Sudan Landge <sudanl@amazon.com>
ShadowCurse
approved these changes
Jan 4, 2024
bchalios
reviewed
Jan 4, 2024
bchalios
reviewed
Jan 4, 2024
bchalios
approved these changes
Jan 5, 2024
pb8o
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
difference as a metric.
Use the Aggregate metrics structure to record aggregate of
IO and MMIO vm exits.
with new metrics for kvm exits this relation changes to "group_metrics:
key_metrics:sub_key_metrics:value".
Update the flush_fc_metrics_to_cw() to be able to parse this and make
it future proof to support further sub_key_metrics levels.
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
- [ ] If a specific issue led to this PR, this PR closes the issue.- [ ] Any required documentation changes (code and docs) are included in this PR.- [ ] API changes follow the Runbook for Firecracker API changes.- [ ] User-facing changes are mentioned inCHANGELOG.md.- [ ] NewTODOs link to an issue.rust-vmm.