skipped unnecessary kvm_immediate_exits #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4388 +/- ##
=======================================
Coverage 82.02% 82.02%
=======================================
Files 253 253
Lines 31035 31046 +11
=======================================
+ Hits 25456 25467 +11
Misses 5579 5579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MatiasT
force-pushed
the
emulation_task
branch
2 times, most recently
from
050bca2
to
59cae55
Compare
MatiasT
force-pushed
the
emulation_task
branch
2 times, most recently
from
f045a54
to
a222eab
Compare
Skipped switches in the presence of run_emulation and VcpuEvent::Resume Signed-off-by: Matias Teragni <mteragni@amazon.com>
roypat
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Apr 2, 2024
roypat
approved these changes
Apr 2, 2024
amondirvin
reviewed
Jul 12, 2024
| @@ -16,7 +16,7 @@ use std::{fmt, io, thread}; | |||
| use kvm_bindings::{KVM_SYSTEM_EVENT_RESET, KVM_SYSTEM_EVENT_SHUTDOWN}; | |||
| use kvm_ioctls::VcpuExit; | |||
| use libc::{c_int, c_void, siginfo_t}; | |||
| use log::{error, info}; | |||
| use log::{error, info, warn}; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipped context switches in the presence of run_emulation and VcpuEvent::Resume if kvm_immediate_exit is set
Changes
run_emulationif `kvm_immediate_exit is setReason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.