fix(cpu-template-helper): ignore wide registers #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
ingnore_sve_helper
branch
from
82300b5
to
a5b4ff2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4409 +/- ##
==========================================
+ Coverage 81.53% 81.54% +0.01%
==========================================
Files 241 241
Lines 29332 29335 +3
==========================================
+ Hits 23916 23922 +6
+ Misses 5416 5413 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
ingnore_sve_helper
branch
from
a5b4ff2
to
6d8b08b
Compare
ShadowCurse
added
Status: Awaiting review
pb8o
reviewed
Jan 26, 2024
ShadowCurse
force-pushed
the
ingnore_sve_helper
branch
from
6d8b08b
to
b95d2db
Compare
zulinx86
previously approved these changes
Jan 26, 2024
pb8o
previously approved these changes
Jan 26, 2024
|
The limitation of cpu templates is documented. But this bug is in the helper tool and it can be visible by users if they try to use it with template that enables wide registers. |
ShadowCurse
requested review from
xmarcalx,
kalyazin and
wearyzen
as code owners
When SVE extension is enabled on aarch64 cpus, KVM will return wide registers when queried. Because cpu templates do not support registers wider than 128 bits we need to ignore wide registers when converting cpu configuration into a cpu template. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
ingnore_sve_helper
branch
from
b225ef7
to
d984556
Compare
zulinx86
reviewed
Jan 29, 2024
Add cpu-template-helper SVE related bug fix to the CHANGELOG. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
ingnore_sve_helper
branch
from
d984556
to
a28d7a1
Compare
pb8o
approved these changes
Jan 29, 2024
zulinx86
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When SVE extension is enabled on aarch64 cpus, KVM will return wide registers when queried. Because cpu templates do not support registers wider than 128 bits we need to ignore wide registers when converting cpu configuration into a cpu template.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.