fix aarch64 not able to restore snaps when SVE enabled #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4413 +/- ##
=======================================
Coverage 81.51% 81.52%
=======================================
Files 241 241
Lines 29282 29296 +14
=======================================
+ Hits 23870 23883 +13
- Misses 5412 5413 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
2 times, most recently
from
d185057
to
59804fc
Compare
ShadowCurse
changed the title
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
3 times, most recently
from
5c6d263
to
a7af7b4
Compare
ShadowCurse
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
ShadowCurse
added
Status: Awaiting review
roypat
reviewed
Jan 29, 2024
pb8o
reviewed
Jan 29, 2024
tests/integration_tests/functional/test_cpu_features_aarch64.py
Outdated
Show resolved
Hide resolved
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
from
a7af7b4
to
92f7d69
Compare
roypat
previously approved these changes
Jan 29, 2024
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
from
92f7d69
to
7599f36
Compare
Replace `set_registers` with `set_register` in order to have more control over each register restoration process. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Split `vcpu_init` and `vcpu_finalize` into separate methods for better flexibility. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
KVM_REG_ARM64_SVE_VLS needs to be treated differently from other SVE registers. It needs to be set before vcpu is finalized. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add verification of cpu features after loading a snapshot of a vm with cpu-template applied. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add verification of cpu features after loading a snapshot of a vm with cpu-template applied. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add firecracker SVE related bug fix to the CHANGELOG. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
from
7599f36
to
8344690
Compare
roypat
approved these changes
Jan 30, 2024
pb8o
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Firecracker is incorrectly handling KVM_REG_ARM64_SVE_VLS register during snapshot restoration. KVM_REG_ARM64_SVE_VLS must be set after vcpu is initialized, but before it is finalized.
This PR fixes this issue.
Additionally cpu-feature related tests were updated to test cpu features after snapshot of a vm with cpu template was restored.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.