Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test to check if killing microvm works as expected #4436

Merged
merged 2 commits into from
Feb 9, 2024
Merged

chore: test to check if killing microvm works as expected #4436

merged 2 commits into from
Feb 9, 2024

Conversation

wearyzen
Copy link
Contributor

@wearyzen wearyzen commented Feb 8, 2024

Changes:

Add a test to make sure there is no change in behaviour in killing firecracker_pid.

Reason:

In our CI we pass --new-pid-ns along with --daemonize and so firecracker pid can be read from the file firecracker.pid present in the jailers root directory.
However, if there is a change in behaviour that leads to this file not having the actual firecracker pid then it could cause a regression.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@wearyzen wearyzen self-assigned this Feb 8, 2024
@wearyzen wearyzen marked this pull request as draft February 8, 2024 17:31
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da9d517) 81.52% compared to head (81b541e) 81.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4436   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         241      241           
  Lines       29296    29296           
=======================================
  Hits        23883    23883           
  Misses       5413     5413           
Flag Coverage Δ
4.14-c5n.metal 78.79% <ø> (ø)
4.14-m5n.metal 78.78% <ø> (ø)
4.14-m6a.metal 77.90% <ø> (ø)
4.14-m6g.metal 76.86% <ø> (ø)
4.14-m6i.metal 78.78% <ø> (ø)
4.14-m7g.metal 76.86% <ø> (ø)
5.10-c5n.metal 81.48% <ø> (ø)
5.10-m5n.metal 81.47% <ø> (ø)
5.10-m6a.metal 80.69% <ø> (ø)
5.10-m6g.metal 79.79% <ø> (ø)
5.10-m6i.metal 81.47% <ø> (ø)
5.10-m7g.metal 79.79% <ø> (ø)
6.1-c5n.metal 81.48% <ø> (ø)
6.1-c7g.metal ?
6.1-m5n.metal 81.47% <ø> (ø)
6.1-m6a.metal 80.69% <ø> (ø)
6.1-m6g.metal 79.79% <ø> (ø)
6.1-m6i.metal 81.47% <ø> (ø)
6.1-m7g.metal 79.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wearyzen wearyzen marked this pull request as ready for review February 8, 2024 18:22
@wearyzen wearyzen added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Feb 8, 2024
tests/framework/microvm.py Outdated Show resolved Hide resolved
@wearyzen wearyzen marked this pull request as draft February 8, 2024 19:06
@wearyzen wearyzen marked this pull request as ready for review February 8, 2024 19:26
tests/framework/microvm.py Show resolved Hide resolved
docs/jailer.md Outdated Show resolved Hide resolved
tests/framework/microvm.py Outdated Show resolved Hide resolved
docs/jailer.md Outdated Show resolved Hide resolved
zulinx86
zulinx86 previously approved these changes Feb 9, 2024
tests/framework/microvm.py Outdated Show resolved Hide resolved
roypat
roypat previously approved these changes Feb 9, 2024
Sudan Landge added 2 commits February 9, 2024 16:36
Change:
Add a test to make sure there is no change in behaviour in
killing firecracker_pid.

Reason:
In our CI we pass `--new-pid-ns` along with `--daemonize` and so
firecracker pid can be read from the file `firecracker.pid`
present in the jailers root directory.
However, if there is a change in behaviour that leads to this file not
having the actual firecracker pid then it could cause a regression.

Signed-off-by: Sudan Landge <sudanl@amazon.com>
da92bf6 commit
changed the behaviour of the pid returned by the jailer so,
add a known limitation explaining that and suggest a workaround
to get the Firecracker pid.

Signed-off-by: Sudan Landge <sudanl@amazon.com>
@wearyzen wearyzen dismissed stale reviews from roypat and zulinx86 via 81b541e February 9, 2024 16:36
@wearyzen wearyzen merged commit 3a7d32c into firecracker-microvm:main Feb 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants