sys_util: enable build for non-musl libraries #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to: #610 |
andreeaflorescu
previously approved these changes
Nov 23, 2018
iliana
previously approved these changes
Nov 23, 2018
alxiord
previously approved these changes
Nov 23, 2018
dianpopa
dismissed stale reviews from alxiord, iliana, and andreeaflorescu
via
519a0d2
The `ioctl` function signature in the musl library differs from that of glibc by having a different type for the request parameter. Thus, this fix enables successful build on other non-musl libraries using a `#cfg` macro. Signed-off-by: Diana Popa <dpopa@amazon.com>
When compiling with GNU there is at least one violation of the seccomp filter: signal: 31, SIGSYS: bad system call. This violation is causing cargo test to exit with error. Signed-off-by: Andreea Florescu <fandree@amazon.com>
Signed-off-by: Diana Popa <dpopa@amazon.com>
Adds a integration tests for ensuring correctness of the doc tests. The doc tests can only be run by using the default host target (i.e GNU). Signed-off-by: Diana Popa <dpopa@amazon.com>
alxiord
approved these changes
Nov 26, 2018
raduweiss
approved these changes
Nov 26, 2018
This was referenced Nov 26, 2018
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ioctlfunction signature in the musl library (i.e musl ioctl.c) differs from that ofglibc (i.e. glibc's ioctl) by having a different type for the request parameter. Thus,
this fix enables successful build on other non-musl libraries using
a
#cfgmacro.How to test this?