Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure multiple NICs #44

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Sep 14, 2019

Issue #, if available:

Description of changes:

Allow using the option -tap-device= multiple times so the VM can have multiple interfaces

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
Copy link
Contributor

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @nmeyerhans can you take a look?

nmeyerhans pushed a commit that referenced this pull request Oct 7, 2019
#44

Signed-off-by: Noah Meyerhans <nmeyerha@amazon.com>
@nmeyerhans nmeyerhans merged commit cb990c3 into firecracker-microvm:master Oct 7, 2019
@nmeyerhans
Copy link
Contributor

Apologies for the late response. The change looks great. Thank you for your contribution, @aojea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants