Skip to content

Commit

Permalink
fix typos
Browse files Browse the repository at this point in the history
drive-by typo fixes during code review
  • Loading branch information
two-heart authored and ripatel-fd committed Aug 4, 2024
1 parent 102e6c1 commit 00a4ef0
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions src/app/fdctl/main1.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ should_colorize( void ) {
static void
initialize_numa_assignments( fd_topo_t * topo ) {
/* Assign workspaces to NUMA nodes. The heuristic here is pretty
simple for now: workspacess go on the NUMA node of the first
simple for now: workspaces go on the NUMA node of the first
tile which maps the largest object in the workspace. */

for( ulong i=0UL; i<topo->wksp_cnt; i++ ) {
Expand Down Expand Up @@ -159,7 +159,7 @@ fdctl_boot( int * pargc,
char * thread = "";
if( FD_UNLIKELY( config_fd >= 0 ) ) {
copy_config_from_fd( config_fd, config );
/* tick_per_ns needs to be synchronized across procesess so that they
/* tick_per_ns needs to be synchronized across processes so that they
can coordinate on metrics measurement. */
fd_tempo_set_tick_per_ns( config->tick_per_ns_mu, config->tick_per_ns_sigma );
} else {
Expand Down
8 changes: 4 additions & 4 deletions src/app/fdctl/run/tiles/fd_poh.c
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,7 @@ during_frag( void * _ctx,
the accounts right after we execute and commit the results to the
accounts database. It has to happen before because otherwise
there's a race where the bank releases the accounts, they get
reuused in another bank, and that bank sends to PoH and gets its
reused in another bank, and that bank sends to PoH and gets its
microblock pulled first -- so the bank commit and poh mixin order
is not the same. Ideally we would resolve this a bit more
cleverly and without holding the account locks this much longer. */
Expand Down Expand Up @@ -1535,9 +1535,9 @@ after_frag( void * _ctx,
for( ulong i=0; i<txn_cnt; i++ ) { executed_txn_cnt += !!(txns[ i ].flags & FD_TXN_P_FLAGS_EXECUTE_SUCCESS); }

/* We don't publish transactions that fail to execute. If all the
transctions failed to execute, the microblock would be empty, causing
agave to think it's a tick and complain. Instead we just skip
the microblock and don't hash or update the hashcnt. */
transactions failed to execute, the microblock would be empty,
causing agave to think it's a tick and complain. Instead, we just
skip the microblock and don't hash or update the hashcnt. */
if( FD_UNLIKELY( !executed_txn_cnt ) ) return;

uchar data[ 64 ];
Expand Down
2 changes: 1 addition & 1 deletion src/app/fdctl/run/tiles/fd_poh_int.c
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ during_frag( void * _ctx,
the accounts right after we execute and commit the results to the
accounts database. It has to happen before because otherwise
there's a race where the bank releases the accounts, they get
reuused in another bank, and that bank sends to PoH and gets its
reused in another bank, and that bank sends to PoH and gets its
microblock pulled first -- so the bank commit and poh mixin order
is not the same. Ideally we would resolve this a bit more
cleverly and without holding the account locks this much longer. */
Expand Down
2 changes: 1 addition & 1 deletion src/flamenco/runtime/tests/generated/invoke.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/flamenco/vm/fd_vm_private.h
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ fd_vm_mem_cfg( fd_vm_t * vm ) {
[haddr,haddr+sz). On success, returns haddr and every byte in the
haddr range is a valid address. On failure, returns sentinel and
there was at least one byte in the virtual address range that did not
have a corresponding byte inthe host address range.
have a corresponding byte in the host address range.
IMPORTANT SAFETY TIP! When sz==0, the return value currently is
arbitrary. This is often fine as there should be no
Expand Down
6 changes: 3 additions & 3 deletions src/flamenco/vm/syscall/fd_vm_syscall_cpi_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
here are templated and will be instantiated for both the C and Rust CPI ABIs.
The only difference between the C and Rust CPI syscalls is the ABI data layout
of the paramaters to these calls - all the logic is identical. As such, we have
of the parameters to these calls - all the logic is identical. As such, we have
defined a series of macros to abstract away the ABI differences from the CPI implementation.
The entry-point for these syscalls is VM_SYSCALL_CPI_ENTRYPOINT.
Expand All @@ -19,7 +19,7 @@
to populate a fd_instr_info_t struct. This struct can then be given to the
FD runtime for execution.
Paramaters:
Parameters:
- vm: handle to the vm
- cpi_instr: instruction to execute laid out in the CPI ABI format (Rust or C)
- cpi_acc_metas: list of account metas, again in the CPI ABI format
Expand Down Expand Up @@ -79,7 +79,7 @@ VM_SYSCALL_CPI_INSTRUCTION_TO_INSTR_FUNC( fd_vm_t * vm,
}

/* The parent flag(s) for is writable/signer is checked in
fd_vm_prepare_instruction. Signer privlege is allowed iff the account
fd_vm_prepare_instruction. Signer privilege is allowed iff the account
is a signer in the caller or if it is a derived signer. */
if( VM_SYSCALL_CPI_ACC_META_IS_WRITABLE( cpi_acct_meta ) ) {
out_instr->acct_flags[i] |= FD_INSTR_ACCT_FLAGS_IS_WRITABLE;
Expand Down
4 changes: 2 additions & 2 deletions src/flamenco/vm/syscall/fd_vm_syscall_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ fd_vm_syscall_sol_alloc_free( /**/ void * _vm,
The most serious issue is that there is nothing to stop VM code
making a decision based on the _location_ of the returned
allocation. If different validator implementations use different
allocator algorithms, though each implemementation would behave
allocator algorithms, though each implementation would behave
functionally correct in isolation, the VM code that uses it would
actually break consensus.
Expand All @@ -312,7 +312,7 @@ fd_vm_syscall_sol_alloc_free( /**/ void * _vm,
uses malloc/free style dynamic allocation is inherently broken. So
this syscall should have never existed in the first place ... it
just feeds the trolls. The above is just additional implementation
horror because people consistent think malloc/free is much simplier
horror because people consistent think malloc/free is much simpler
than it actually is. This is also an example of how quickly
mistakes fossilize and become a thorn-in-the-side forever.
Expand Down

0 comments on commit 00a4ef0

Please sign in to comment.